Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair test based on dates (test_create_featured_items) #2229

Merged
merged 2 commits into from
May 30, 2024
Merged

Repair test based on dates (test_create_featured_items) #2229

merged 2 commits into from
May 30, 2024

Conversation

collinpreston
Copy link
Contributor

What are the relevant tickets?

NA

Description (What does it do?)

Repairs a flaky test (test_create_featured_items) that is dependent upon Course and CourseRun dates when filtering.

How can this be tested?

Unit tests should always pass.

@annagav annagav self-requested a review May 30, 2024 12:39
@annagav annagav self-assigned this May 30, 2024
annagav
annagav approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@collinpreston collinpreston merged commit c969aab into main May 30, 2024
7 checks passed
@collinpreston collinpreston deleted the repair-feature-item-cache-unit-test branch May 30, 2024 13:01
@odlbot odlbot mentioned this pull request May 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagav annagav annagav approved these changes

Assignees

@annagav annagav

Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collinpreston @annagav